Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TPM installation not working / installation causes conflicts in plugins directory (Consider renaming repository?) #129

Open
fazlearefin opened this issue Jan 30, 2024 · 4 comments
Assignees

Comments

@fazlearefin
Copy link

When using this plugin, it creates a dir in the tmux plugs dir named tmux. This can potentially cause issues with other plugins named tmux in the same folder in the future

$ ls -ld ~/.tmux/plugins
tmux
tmux-sensible
tmux-yank
tpm

Other themes are named with a more unique name:

  • tmux-peacock
  • tmux-dark-notify
  • tmux-colours-superhero

I recommend naming this git repo something like tmux-catppuccin instead of tmux so that is it more unique and does not cause any naming clashes in the future.

@igops
Copy link

igops commented Jan 30, 2024

+1 #120 (comment)

@sgoudham sgoudham self-assigned this Mar 6, 2024
@sgoudham sgoudham changed the title Rename git repo to something like tmux-catppuccin instead of tmux TPM installation not working/installing as tmux causing conflicts (Consider renaming repository?) Mar 6, 2024
@sgoudham sgoudham changed the title TPM installation not working/installing as tmux causing conflicts (Consider renaming repository?) TPM installation not working / installation causes conflicts in plugins directory (Consider renaming repository?) Mar 7, 2024
@sgoudham
Copy link
Contributor

sgoudham commented Mar 8, 2024

Hi, I'm one of the core maintainers of Catppuccin 👋

From an organisation perspective, I'd like to avoid renaming this repository as it goes against our naming convention for applications that we support. We ran into a similar situation with our catppuccin/nvim repository, but the plugin managers for that ecosystem allowed plugins to be downloaded under a different name.

In the other issues that have been raised, I can see that tpm itself has an issue and a PR that aims to "fix" this:

While waiting for tpm to (hopefully) allow overrides to plugin names, I can think of 2 immediate "workarounds":

  1. We can put a notice in the README that users should check if they have a tmux directory already in their plugins directory, and if they do, they should delete it. (My question now is, can you rename plugins downloaded via TPM without things breaking? If so, we should tell users to rename the plugin locally once its downloaded and it should be fine?)
  2. We could explicitly encourage users to fork the GitHub repository under their own name (e.g. tmux-catppuccin) to their own account, and then to run set -g @plugin '<username>/tmux-catppuccin'. I don't actually mind this too much since this is such a dotfiles centric repository and its already forked quite a bit because users (somewhat obviously) enjoy tweaking the configuration from the base provided here.

Curious what others think!

@sgoudham sgoudham pinned this issue Mar 17, 2024
@vdbe vdbe mentioned this issue May 16, 2024
1 task
@mike-rambil
Copy link

I tried forking it using new names from my repo as well as other people repo but it is still not working?

what am I doing wrong?

Here are the steps that I did:

set -g @plugin 'tmux-plugins/tpm'
set -g @plugin 'tmux-plugins/tmux-sensible'
set -g @plugin 'mike-rambil/tmux-catppuccin'

set -g @catppuccin_flavour 'mocha'

run '~/.config/tmux/plugins/tpm/tpm'

After this, I did ctrl B + I and it installs the plugin with the new name but I don't see any changes?

@tianpai
Copy link

tianpai commented Jul 28, 2024

I tried forking it using new names from my repo as well as other people repo but it is still not working?

what am I doing wrong?

Here are the steps that I did:

set -g @plugin 'tmux-plugins/tpm'
set -g @plugin 'tmux-plugins/tmux-sensible'
set -g @plugin 'mike-rambil/tmux-catppuccin'

set -g @catppuccin_flavour 'mocha'

run '~/.config/tmux/plugins/tpm/tpm'

After this, I did ctrl B + I and it installs the plugin with the new name but I don't see any changes?

I tried using your repo, it worked for me. (I completely rm -rf the plugin of mine catppuccin and installed mike-rambil/tmux-catppuccin)

The last line seems to show that you installed tpm not in the default path. I don't know if this would help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants