Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dxtbx.plot_detector_models orthographic=False broken in current matplotlib #573

Closed
dagewa opened this issue Nov 7, 2022 · 0 comments · Fixed by #574
Closed

dxtbx.plot_detector_models orthographic=False broken in current matplotlib #573

dagewa opened this issue Nov 7, 2022 · 0 comments · Fixed by #574
Assignees
@phyy-nx

Comments

@dagewa
Copy link
Member

dagewa commented Nov 7, 2022

While testing for #570 I found that this program fails with default parameters (orthographic=False). The problem is that this relies on previously deprecated, and now removed, matplotlib code

dxtbx/src/dxtbx/command_line/plot_detector_models.py

Line 184 in 587a263

ax = fig.gca(projection="3d")

See e.g. matplotlib/matplotlib#20770
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phyy-nx phyy-nx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix dxtbx.plot_detector_models for new versions of matplotlib cctbx/dxtbx
2 participants
@dagewa @phyy-nx