Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testsuite uri field inconsistent between testsuiterunqueued and the other two testsuite schema definitions. #160

Open
obowersa opened this issue Aug 25, 2023 · 0 comments
Labels
breaking change Indicates when a PR or issue will have breaking changes
Milestone

Comments

@obowersa
Copy link
Contributor

Within the testsuiterunqueued schema, the testsuite object has a field called 'url':

Within testsuiterunfinished and testsuiterunstarted this is referred to as 'uri'.

uri also matches what is in the testing events markdown doc.

It feels like the url field in the testsuiterunqueued schema is incorrect and should be aligned with the other test suite references, but, I wanted to check in case this was deliberate.

obowersa added a commit to obowersa/spec that referenced this issue Aug 25, 2023
The pipelineququerequested schema uses the field uri instead of url. This is different from the two other pipeline schemas and different from the markdown docs for the schema.

This is related to the following issue: cdevents#160

Signed-off-by: Owen Bower Adams <owen+github@obowersa.net>
obowersa added a commit to obowersa/spec that referenced this issue Aug 25, 2023
The testsuiterunqueued schema uses the field url under testsuite. Within the other testsuite run schemas, uri is used. This is also used in the markdown documents.

This change updates the testsuiterunqueued schema to bring it in line with the other testsuite's

This is in relation to: cdevents#160

Signed-off-by: Owen Bower Adams <owen+github@obowersa.net>
@afrittoli afrittoli added this to the v0.4 milestone Mar 4, 2024
@afrittoli afrittoli modified the milestones: v0.4, v0.5 Apr 8, 2024
@xibz xibz added the breaking change Indicates when a PR or issue will have breaking changes label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Indicates when a PR or issue will have breaking changes
Projects
None yet
Development

No branches or pull requests

3 participants