Skip to content
This repository has been archived by the owner on Aug 27, 2022. It is now read-only.

Change Snippet class structure to be compatible with W3C pointer definition #14

Open
goneall opened this issue Jan 9, 2020 · 4 comments

Comments

@goneall
Copy link
Collaborator

goneall commented Jan 9, 2020

Propose changing the SBOM Snippet class structure and attribute names to be compatible with SPDX and W3C pointer definitions

Add classes StartEndPointer, (abstract) singlePointer, byteRangePointer and LineCharPointer
Add properties byteRange and lineRange with type StartEndPointer

@CASTResearchLabs
Copy link
Collaborator

it came from the SPDX 3.0 draft I received
it was also a simplification from a previous model where there were many classes to handle the ranges

@goneall
Copy link
Collaborator Author

goneall commented Jan 14, 2020

it was also a simplification from a previous model where there were many classes to handle the ranges

Make a lot of sense. The Snippets in SPDX do have a lot of classes. The root cause of this is a desire to incorporate existing standard with the same meaning, which in this case is the W3C Pointer classes. The W3C classes are IMHO complex.

Does OMG have a similar objective of reusing existing standards? If so, I would suggest following the same somewhat more complex solution. If not, it would be worth considering a simplification.

Snippets are are only used in a small number of use cases, so the SPDX compatibility issues may not be as significant (although I would still prefer compatibility if there isn't a significant advantage to the alternative).

@goneall
Copy link
Collaborator Author

goneall commented Jan 15, 2020

@iamwillbar any thoughts on the proposal?

@iamwillbar
Copy link

That's fine with me, the draft was more about structure than specific attribute names and types.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants