Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profiles saved with WebP output only load default settings #567

Closed
jpert opened this issue Jun 26, 2024 · 3 comments
Closed

Profiles saved with WebP output only load default settings #567

jpert opened this issue Jun 26, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@jpert
Copy link

jpert commented Jun 26, 2024

FastFlix Version:
5.7.1

Operating System:
Win 11 Pro 22631.3737

Describe the bug
Any profile using the WebP output module doesn't actually recall saved settings for that module. Regardless of what parameters are saved in GUI with a new profile it only loads the module defaults for the 4 changeable parameters (lossless, compression level, preset and qscale)

To Reproduce
Load a source, load the WebP output module, modify the output parameters from default and save a new profile. Now change the output module to anything else. Finally, load your newly created WebP profile and see that it only loads the module defaults and not the modified settings you saved

@jpert jpert added the bug Something isn't working label Jun 26, 2024
cdgriffith added a commit that referenced this issue Aug 7, 2024
… to jpert)

* Fixing #582 BT.2020-10 Color transfer not maintained #582 (thanks to Ryushin)
@cdgriffith
Copy link
Owner

Thank you for the details of this issues! Found multiple causes with this and also affected some other items, so was able to fix up a lot with this brought to my attention.

Will be fixed in 5.8.0, currently in beta if you can test: https://github.com/cdgriffith/FastFlix/releases/tag/5.8.0b0

cdgriffith added a commit that referenced this issue Aug 9, 2024
* Adding #283 support for experimental DTS (dca) audio by adding -strict -2 (thanks to Sub7)
* Adding #354 M1 support (thanks to Nhunz and Anton)
* Adding #536 Improve Profiles - save advanced options (thanks to CelticTaonga and DCNerds)
* Adding #568 center app on startup (thanks to Viet-Duc Le)
* Adding #589 support for pydantic 2.x (thanks to dmo marillat)
* Adding #592 Add alpha channel for VP9 (thjanks to subof)
* Fixing #185 audio channels not being set properly and resetting on encoder change (thanks to Tupsi)
* Fixing #522 add file fails - fixed as of 5.7.0 (thanks to pcl5x2008)
* Fixing #531 list limitation in readme that FFmpeg must support the software encoders listed (thanks to brunoais)
* Fixing #567 Profiles for WebP did not work (nor GIF dither) (thanks to jpert)
* Fixing #582 BT.2020-10 Color transfer not maintained (thanks to Ryushin)
* Fixing #585 error when trying to return a video from queue that has the video track after audio or subtitiles (thanks to Hankuu)
* Fixing #586 audio channels being set incorrectly (thanks to Hankuu)
* Fixing #588 audio and subtitle dispositions were not set from source (thanks to GeZorTenPlotZ)
@cdgriffith
Copy link
Owner

@jpert
Copy link
Author

jpert commented Aug 9, 2024

a 47 hour beta to release turnaround? Amazing. Didn't get a chance to test though but I'll put the webp module through it's paces and let you know if all look well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants