From 14d266b0bb6527388bb71babc6896c0bb27b1620 Mon Sep 17 00:00:00 2001 From: Sumu Date: Thu, 21 Sep 2023 15:23:13 -0400 Subject: [PATCH 1/4] add notice to notices.json Signed-off-by: Sumu --- data/notices.json | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/data/notices.json b/data/notices.json index cd0ecbc..26b1a6f 100644 --- a/data/notices.json +++ b/data/notices.json @@ -283,6 +283,18 @@ } ], "schemaVersion": "1" + }, + { + "title": "ecs breaking change renaming prop in ContainerImage.fromEcrRepository", + "issueNumber": 27240, + "overview": "Renaming a prop in ContainerImage.fromEcrRepository function introduces a breaking change, not for typescript users, but for other languages that require specifying the property name when calling the function.", + "components": [ + { + "name": "aws-cdk-lib.aws-ecs.ContainerImage.fromEcrRepository", + "version": "2.96.0" + } + ], + "schemaVersion": "1" } ] } From 12cf6a0d8cb2764ad78647488e94e14d32a2b143 Mon Sep 17 00:00:00 2001 From: Sumu Pitchayan <35242245+sumupitchayan@users.noreply.github.com> Date: Fri, 22 Sep 2023 08:00:31 -0400 Subject: [PATCH 2/4] Update data/notices.json Co-authored-by: Otavio Macedo <288203+otaviomacedo@users.noreply.github.com> --- data/notices.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/notices.json b/data/notices.json index 26b1a6f..b2ac7a1 100644 --- a/data/notices.json +++ b/data/notices.json @@ -290,7 +290,7 @@ "overview": "Renaming a prop in ContainerImage.fromEcrRepository function introduces a breaking change, not for typescript users, but for other languages that require specifying the property name when calling the function.", "components": [ { - "name": "aws-cdk-lib.aws-ecs.ContainerImage.fromEcrRepository", + "name": "aws-cdk-lib.aws-ecs.ContainerImage", "version": "2.96.0" } ], From 36b9c5e38fdf4a45495a5ec1ae2c4e763f63cb79 Mon Sep 17 00:00:00 2001 From: Sumu Pitchayan <35242245+sumupitchayan@users.noreply.github.com> Date: Fri, 22 Sep 2023 08:00:48 -0400 Subject: [PATCH 3/4] Update data/notices.json Co-authored-by: Otavio Macedo <288203+otaviomacedo@users.noreply.github.com> --- data/notices.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/notices.json b/data/notices.json index b2ac7a1..fefc6e5 100644 --- a/data/notices.json +++ b/data/notices.json @@ -285,7 +285,7 @@ "schemaVersion": "1" }, { - "title": "ecs breaking change renaming prop in ContainerImage.fromEcrRepository", + "title": "Unexpected keyword argument 'tag' when calling ContainerImage.fromEcrRepository", "issueNumber": 27240, "overview": "Renaming a prop in ContainerImage.fromEcrRepository function introduces a breaking change, not for typescript users, but for other languages that require specifying the property name when calling the function.", "components": [ From d824feecaa9cde94ca2e0c6c34882c0f40d90d29 Mon Sep 17 00:00:00 2001 From: Sumu Date: Fri, 22 Sep 2023 08:04:33 -0400 Subject: [PATCH 4/4] rico's suggestion, make it clear env is python specifically Signed-off-by: Sumu --- data/notices.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/notices.json b/data/notices.json index fefc6e5..39f46e5 100644 --- a/data/notices.json +++ b/data/notices.json @@ -287,7 +287,7 @@ { "title": "Unexpected keyword argument 'tag' when calling ContainerImage.fromEcrRepository", "issueNumber": 27240, - "overview": "Renaming a prop in ContainerImage.fromEcrRepository function introduces a breaking change, not for typescript users, but for other languages that require specifying the property name when calling the function.", + "overview": "Renaming the 'tag' prop to 'tagOrDigest' in ContainerImage.fromEcrRepository function introduces a breaking change in Python when using keyword parameters.", "components": [ { "name": "aws-cdk-lib.aws-ecs.ContainerImage",