-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: fix lambda examples fail with error
ENAMETOOLONG
(#206)
Resolves #164 Note this changes removes running (some) tests in a temporary working dir. Changing the working directory breaks assumptions about the CWD for file paths. There was no apparent reason why this was introduced in the first place in #110. There is an open question about how we want to deal with relative file paths. The two options are: - relative to the CWD - relative to the template There is a comment in [deconstruction.ts](https://github.com/cdklabs/decdk/blob/ee07573d61a470288890d14d739dfb88092b51b8/src/deconstruction.ts#L853-L854) that indicates it should be relative to the template file. However the current implementation in [decdk.ts](https://github.com/cdklabs/decdk/blob/145238a53f1f9f8db5c1808500e6bac4c8a0d4a1/src/decdk.ts#L25) does NOT do that (note the missing `workingDirectory` prop). I've left it at the current implementation (relative to the CWD) for now, which I think is also closer to how imperative CDK behaves. In future the most transparent might be a command line option. Related #200
- Loading branch information
Showing
8 changed files
with
36 additions
and
26 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
exports.handler = async function() { | ||
return 'SUCCESS'; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters