Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLS 99 add endpoint for getting all messages for account #2

Merged
merged 10 commits into from
Oct 26, 2023
Merged

CLS 99 add endpoint for getting all messages for account #2

merged 10 commits into from
Oct 26, 2023

Conversation

vvuwei
Copy link
Member

@vvuwei vvuwei commented Oct 26, 2023

  • added address/{hash}/messages endpoint
  • added requests for namespace and updated gitignore to ignore private configs
  • added requests for namespace
  • added convert from MsgAddress to response.Message
  • added filtering for addresses messages
  • added unit test for storage.Address.Messages
  • added unit test for address messages endpoint

@vvuwei vvuwei requested a review from aopoltorzhicky October 26, 2023 13:39
@vvuwei vvuwei self-assigned this Oct 26, 2023
@vvuwei vvuwei added the feature New feature or request label Oct 26, 2023
@vvuwei vvuwei added this to the v1.0.0 milestone Oct 26, 2023
aopoltorzhicky
aopoltorzhicky requested changes Oct 26, 2023
View reviewed changes
Copy link
Member

@aopoltorzhicky aopoltorzhicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub shows me hashpathstring in one word

aopoltorzhicky
aopoltorzhicky requested changes Oct 26, 2023
View reviewed changes
Copy link
Member

@aopoltorzhicky aopoltorzhicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And you have to regenerate api docs

@vvuwei
Copy link
Member Author

vvuwei commented Oct 26, 2023

And you have to regenerate api docs

thanks, done

@vvuwei vvuwei merged commit a773784 into master Oct 26, 2023
3 checks passed
@vvuwei vvuwei deleted the CLS-99-add-endpoint-for-getting-all-messages-for-account branch October 26, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aopoltorzhicky aopoltorzhicky aopoltorzhicky approved these changes

Assignees

@vvuwei vvuwei

Labels
feature New feature or request
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@vvuwei @aopoltorzhicky