-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing rule?: Variables cannot have true/false as value #308
Comments
Nope, we decided to leave it. See #29 |
That was about having the |
So you could have a variable evaluate to a boolean value in the MathML, but you're just not allowed to assign it a boolean value yourself? See #29 (comment) ? |
I'd say "x = true" shouldn't be allowed, nor should "x = (1 == 2)" |
I'd be concerned about embarking down the path of defining what was allowed in the math. Currently we only say "these are the allowed elements from MathML2" and don't really care if people make bad models. This particular case could be something added to the libcellml checking for "bad math" that would help people develop more robust models, but I don't see a need to rule it out in the specification. If we did open up this case, then you'd expect a whole slew of such rules that try to define what a good model is, or at least ruling out all the things we know are bad. Its also maybe useful to remember that our models are all equalities, there is no assignment operator. |
We're already not allowing |
We're currently not ruling out
x = true
, as far as I can see, although I thought this had been our intention?The text was updated successfully, but these errors were encountered: