-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can resets change variables of integration? #327
Comments
yeah. should be |
Hmm ... we need to make it clearer that values of p can't change then. At the moment the reading I got (from elsewhere, not the intro page) was that they were the set of non-integrated variables, but that resets could change them... I guess 2. says not though. |
I only changed it last week to have that big preamble defining x, t, an p, so it's not really clear throughout the doc yet |
and the document might be inconsistent at some points, because I used to think But that was quite a late realisation! |
OK, I'll keep an eye out... though I wonder whether it's actually needed to define them like this? You've used the terminology in a few of the examples at the beginning, but then just say "system values don't change" or something like that in the later ones? Do you have a preference for which is used where, or is there a reason for the change? |
Just trying to clarify |
But is it an eternal truth to say A = B and then reset the value of B or A? Or are we totally forbidding changes to non-integrated variables? |
Hmmm ... thinking about it again, what about this:
.. so in this example |
Not non-integrated variables. The set |
So if |
Here |
t: Free variables, not set by the model in any way |
maybe we should call x: anything that you want to reset ... and then say that it must be defined with an initial condition? |
So A = B in the reset is only an assignment, not an eternal truth? As in this example: |
Not sure! I think of them as changes to apply, not eternal truths. Maybe we can come up with an example where it matters? |
In the introduction page we say:
... but later on we use the terms (x', t', p') to describe the new state after reset. I wouldn't have thought that t could change? so should be (x', t, p') instead?
See here for an example: https://cellml-specification-dev.readthedocs.io/en/i324_examples_chapter/reference/examples/resets/reset_example_3_orderofevaluation.html
The text was updated successfully, but these errors were encountered: