Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content - review all pages #493

Closed
4 tasks done
Tracked by #473
RobTobias123 opened this issue Mar 8, 2024 · 30 comments
Closed
4 tasks done
Tracked by #473

Content - review all pages #493

RobTobias123 opened this issue Mar 8, 2024 · 30 comments
Labels
Epic Epic ticket Status: Completed Nothing further to be done with this issue. Awaiting to be closed Type: Documentation Improvements or additions to documentation

Comments

@RobTobias123
Copy link
Contributor

RobTobias123 commented Mar 8, 2024

Outcome

All page content assessed and long form content pages corrected for textual inaccuracies, spelling mistakes, missing sections, missing or inconsistent headings, missing punctuation, broken links, etc. (Any major decision points and directions taken, highlighted and noted here).

Scope

This would be the minimum required before launch. Following on from that the intention is to use suitable predefined criteria or AI prompts in a tool such as Grammarly or Co-pilot to create a consistent tone of voice, improve grammar, clarity, correctness, and how engaging the content may be to the intended audience. (Briefly explored 7 March by Drew, Mekala, Rob).

Preset criteria using Grammarly to help assess content:

Audience:
Knowledgable. Requires focus to read and understand.

Formality:
Neutral. Restricts slang but allows standard casual expressions.

Domain:
General. (only option of free account)

Intent:
Inform.

Address correctness (spelling, articulation grammar etc.) and clarity alerts.
Manually find and replace any slanted quote marks or apostrophes and replace with straight variants.
Use double quotes (straight) only where a quote is verbatim, otherwise use single quotes.

@RobTobias123 RobTobias123 added the Type: Documentation Improvements or additions to documentation label Mar 8, 2024
@RobTobias123 RobTobias123 self-assigned this Mar 8, 2024
@RobTobias123
Copy link
Contributor Author

I'm making a start on the Guidelines section.

@RobTobias123
Copy link
Contributor Author

Guidelines/Principles assessed and corrected.

PR for review please: #495

@RobTobias123 RobTobias123 added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Mar 8, 2024
@RobTobias123
Copy link
Contributor Author

RobTobias123 commented Mar 11, 2024

Guidelines/Accessibility page assessed and corrected. Plus commented out a link to a Web Accessibility Toolbar tool that no longer appears to be available at https://developer.paciellogroup.com/resources/wat/

PR for review please: https://github.com/centrica-engineering/nucleus-docs/pull/497

@RobTobias123
Copy link
Contributor Author

Guidelines/Principles suggestions applied and updated usage of quote mark types as agreed:

PR for review please: #495

@RobTobias123
Copy link
Contributor Author

Updated Guidelines/Accessibility to new branch independent of principles branch. Update link in post above to #497 and deleted #496.

@RobTobias123
Copy link
Contributor Author

Updated Guidelines/Typography page.

Corrected spelling and grammar. Applied a 'purpose' div style to leading sentence to retain consistency with other pages. Changed 'Related links' from H3 to H2 as it applies to all, not just the Semantics vs. Styles section.

PR for review please: #499

@RobTobias123
Copy link
Contributor Author

Updated Guidelines/Lists page.

Corrected spelling, grammar and punctuation and improved consistency (eg. list/lists etc.)

PR for review please: #500

@RobTobias123
Copy link
Contributor Author

All PRs above have been updated to use 'third-person' and present tense where applicable, as requested and due to common trends observed. This method will be additionally and consistently applied to all pages to be reviewed in this ticket.

@RobTobias123
Copy link
Contributor Author

RobTobias123 commented Mar 11, 2024

Updated Guidelines/Assets page.

PR for review please: #504

I've added a question on the display of ratios within body text that requires a decision.

@RobTobias123
Copy link
Contributor Author

Updated Guidelines/Tokens

Updated grammar and made in the third person. Typography paragraph consistent with Typography page wording.

PR for review please: #508

@RobTobias123
Copy link
Contributor Author

Merged the approved PR #495 Principles page.

@RobTobias123
Copy link
Contributor Author

PR #499 Typography page was approved and merged

@RobTobias123
Copy link
Contributor Author

PR #500 Lists page was approved and merged

@RobTobias123
Copy link
Contributor Author

Updated Guidelines/Working with Nucleus

Updated grammar, punctuation, corrected spellings, improved clarity etc. Consistently applied a lead paragraph style to para steps 1-3, re-written in the 3rd party.

PR for review please: #509

@RobTobias123
Copy link
Contributor Author

Updated Guidelines/Process

Rewritten in third person, corrected grammar and punctuation etc.

PR for review please: #510

@RobTobias123
Copy link
Contributor Author

Approved and Merged #497

@RobTobias123
Copy link
Contributor Author

Approved and merged #509

@RobTobias123
Copy link
Contributor Author

Updated #504 Assets - Aspect ratios info following comments. Please review/approve.

@RobTobias123
Copy link
Contributor Author

Approved and merged #510

@RobTobias123
Copy link
Contributor Author

Assets #504 approved and merged.

@RobTobias123 RobTobias123 removed the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Mar 13, 2024
@RobTobias123
Copy link
Contributor Author

Updated remaining Guidlines pages for contributing, vanilla first and devices.

PRs for review please:

Contributing #513
Vanilla first #514
Devices #515

@RobTobias123 RobTobias123 added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Mar 13, 2024
@RobTobias123
Copy link
Contributor Author

Introduction page with updated grammar, punctuation and spelling and rewrote in the third person.

PR for review please: #517

@RobTobias123
Copy link
Contributor Author

Updated #513 based on suggestions. Please check you're happy with the changes.

@RobTobias123
Copy link
Contributor Author

Approved and merged #514

@RobTobias123
Copy link
Contributor Author

Updated #515 based on suggestion. Please check you're happy with the changes.

@RobTobias123
Copy link
Contributor Author

Approved and merged #517

@RobTobias123
Copy link
Contributor Author

Home page content considered and adjusted. PR for review please:
#520

@RobTobias123
Copy link
Contributor Author

#513 contributions approved and merged.

@RobTobias123
Copy link
Contributor Author

Approved and merged #515 (devices).

@RobTobias123 RobTobias123 added the Epic Epic ticket label Mar 18, 2024
@RobTobias123 RobTobias123 removed the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Mar 26, 2024
@RobTobias123
Copy link
Contributor Author

do donts of Patterns/ Telephone Numbers was updated. PR for review: #595

@RobTobias123 RobTobias123 added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Mar 27, 2024
@andij andij added Status: Completed Nothing further to be done with this issue. Awaiting to be closed and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Mar 28, 2024
@andij andij closed this as completed Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic Epic ticket Status: Completed Nothing further to be done with this issue. Awaiting to be closed Type: Documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants