Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSD collector does not detect encrypted bluestore devices #220

Open
wyllys66 opened this issue Aug 23, 2018 · 1 comment
Open

OSD collector does not detect encrypted bluestore devices #220

wyllys66 opened this issue Aug 23, 2018 · 1 comment
Labels

Comments

@wyllys66
Copy link

wyllys66 commented Aug 23, 2018

The code for detecting whether or not an OSD is encrypted does not do any checking if the device is bluestore., it just assumes "encrypted = 0".

One possible fix would be to check the path of the block device, similar to the filestore check:

linkpath = os.readlink(block_link)
encrypted = linkpath.startswith('/dev/mapper')
@pcuzner
Copy link
Contributor

pcuzner commented Aug 24, 2018

the code pre-dates the the introduction of ceph-volume and lvm based OSDs. Unless I'm mistaken, just checking for the /dev/mapper entry would pick up and OSD defined with LVM too. I think the fact that an osd is encrypted should be part of the osd metadata, which could then be exposed by the prometheus exporter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants