Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample code error #5

Open
defunkydrummer opened this issue Jan 31, 2019 · 1 comment
Open

Sample code error #5

defunkydrummer opened this issue Jan 31, 2019 · 1 comment
Assignees
Labels

Comments

@defunkydrummer
Copy link

Hi @eudoxia0

The example code on the documentation has some errors that prevent an easy tryout of the lib, at least in windows.

  1. When calling make-context by default, server will be 0.0.0.0; this wouldn't work on windows systems.

It must be something like:

(remote-js:make-context 
                    :address "127.0.0.1"
                    :port 40000)

1.1 Context IP address needs to be a string otherwise the produced HTML won't work. I mention this, because the usual convention on other libs is to specify IP address as a vector of ints.

1.2 This makes the remote-js test fail, at least on Windows, since it sets address to 0.0.0.0

1.2.1 And it will fail anyways, since trivial-open-browser invokes "explorer " which opens a file explorer and no url.

  1. The context server needs to be started to be used. This isn't mentioned on the documentation.
@eudoxia0 eudoxia0 self-assigned this Feb 2, 2019
@eudoxia0 eudoxia0 added the bug label Feb 2, 2019
@Symbolics
Copy link

@defunkydrummer, thanks for this. I just ran into the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants