-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sample code error #5
Labels
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi @eudoxia0
The example code on the documentation has some errors that prevent an easy tryout of the lib, at least in windows.
It must be something like:
1.1 Context IP address needs to be a string otherwise the produced HTML won't work. I mention this, because the usual convention on other libs is to specify IP address as a vector of ints.
1.2 This makes the remote-js test fail, at least on Windows, since it sets address to 0.0.0.0
1.2.1 And it will fail anyways, since trivial-open-browser invokes "explorer " which opens a file explorer and no url.
The text was updated successfully, but these errors were encountered: