Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sunset pubkey_to_g1 script + binaries in bolt-contracts #421

Open
merklefruit opened this issue Nov 25, 2024 · 2 comments
Open

chore: sunset pubkey_to_g1 script + binaries in bolt-contracts #421

merklefruit opened this issue Nov 25, 2024 · 2 comments
Labels
C: smart-contracts Component: smart contracts T: chore Type: Chore
Milestone

Comments

@merklefruit
Copy link
Collaborator

We don't need these anymore, as the bolt CLI handles registration in a way more ergonomic fashion.

@merklefruit merklefruit added C: smart-contracts Component: smart contracts T: chore Type: Chore labels Nov 25, 2024
@thedevbirb
Copy link
Contributor

Right, my bad I forgot to clean them up during #392

@merklefruit
Copy link
Collaborator Author

The only annoying thing is that we use pubkey_to_g1_wrapper.sh in BoltValidators*.t.sol here https://github.com/chainbound/bolt/blob/unstable/bolt-contracts/test/BoltValidatorsV2.t.sol#L154

So we either need to move this to a bolt pubkey to-g1 0x... command, but this will also require the bolt cli installed when running tests, or remove the test, or read these g1 points from somewhere else...

@mempirate mempirate added this to the v0.3.1 milestone Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: smart-contracts Component: smart contracts T: chore Type: Chore
Projects
None yet
Development

No branches or pull requests

3 participants