chore(sidecar): update constraint api #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merklefruit
reviewed
Sep 25, 2024
bolt-sidecar/src/crypto/bls.rs
Outdated
Comment on lines
141
to
142
| #[tokio::test] | ||
| async fn generate_test_data() { |
There was a problem hiding this comment.
I understand why you created this test and it looks good, however I would suggest moving it out of the bls module. Not fully sure where yet, but here it's a bit confusing IMO
There was a problem hiding this comment.
yeah I agree. I think src/test_util.rs might be a good place? I just thought of keeping this because will be helpful in future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR -
constraintsfield totransactions