fix: update types & drop bundle support #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedevbirb
reviewed
Oct 2, 2024
Comment on lines
+231
to
+241
| let signed_constraints = match self.constraint_signer.sign(&message.digest()).await { | ||
| Ok(signature) => SignedConstraints { message, signature }, | ||
| Err(err) => { | ||
| error!(?err, "Failed to sign constraints"); | ||
| let _ = response.send(Err(CommitmentError::Internal)); | ||
| return; | ||
| } | ||
| }; | ||
|
|
||
| ApiMetrics::increment_transactions_preconfirmed(tx_type); | ||
| self.execution.add_constraint(slot, signed_constraints); |
There was a problem hiding this comment.
Does this work if a transaction appears twice, first time in a commitment request with just one tx and the second time in a commitment with a batch of two transactions?
Because there is a risk otherwise we increment the nonce of balance of the user two times
There was a problem hiding this comment.
I created a quick test with a duplicate tx in a batch, which should and does fail with nonce too low. It's not exactly what you described but should cover it.
merklefruit
approved these changes
Oct 3, 2024
thedevbirb
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #217