Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sidecar): commit boost flag rename #275

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Conversation

thedevbirb
Copy link
Contributor

Imo the existing commit_boost_address flag doesn't convey properly that an URL should be passed, so the flag has been renamed.

@thedevbirb thedevbirb added C: bolt-sidecar Component: bolt-sidecar T: chore Type: Chore labels Oct 7, 2024
@thedevbirb thedevbirb force-pushed the fix/commit-boost-flag branch from 8fa92e1 to e439a66 Compare October 7, 2024 11:32
@thedevbirb thedevbirb requested a review from mempirate October 7, 2024 15:06
Copy link
Contributor

@mempirate mempirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

bolt-sidecar/src/client/commit_boost.rs Outdated Show resolved Hide resolved
@thedevbirb thedevbirb force-pushed the fix/commit-boost-flag branch from e439a66 to b6e9587 Compare October 7, 2024 15:33
@thedevbirb thedevbirb merged commit 3468c43 into unstable Oct 7, 2024
3 checks passed
@thedevbirb thedevbirb deleted the fix/commit-boost-flag branch October 7, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: bolt-sidecar Component: bolt-sidecar T: chore Type: Chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants