Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sidecar): mog unused dependencies with cargo-machete #402

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

merklefruit
Copy link
Collaborator

Used cargo-machete to remove unused dependencies in bolt-sidecar

~/bolt/bolt-sidecar ❯ cargo machete
Analyzing dependencies of crates in this directory...
cargo-machete didn't find any unused dependencies in this directory. Good job!

I also took the opportunity to:

  • pin leftover unpinned git dependencies
  • slightly refactor the sidecar entry binary
  • remove reth-rpc-layer dependency by copying a 10-line utility function that uses all alloy types


# alloy
alloy = { version = "0.6.3", features = [
alloy = { version = "0.6.4", features = [
"full",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if we need full here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we remove it we'll have to add a bunch of other features in its place, but I haven't tried

@mempirate
Copy link
Contributor

mempirate commented Nov 21, 2024

Symbiotic links are failing - ignored them in #407 so can just rebase

@merklefruit merklefruit merged commit ed6e38c into unstable Nov 21, 2024
2 of 3 checks passed
@merklefruit merklefruit deleted the chore/machete branch November 21, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants