chore(bolt-sidecar): fix lints

[estensen]

Ran cargo clippy locally and CI is running cargo clippy --all-targets --all-features -- -D warnings

[merklefruit]

It would be nice to add quick recipes for linting in the justfile, something like

clippy package:
	cd {{ package }} && cargo clippy --all-targets --all-features -- -D warnings

so we can do just clippy bolt-sidecar

[estensen]

It would be nice to add quick recipes for linting in the justfile, something like

clippy package:
	cd {{ package }} && cargo clippy --all-targets --all-features -- -D warnings

so we can do just clippy bolt-sidecar

Great idea!
#436

[mempirate]

@estensen @merklefruit you could even install this in a pre-commit hook

[estensen]

@estensen @merklefruit you could even install this in a pre-commit hook

yes, but let's improve it one commit at a time

[merklefruit]

pre-commit hook

My personal opinion is that CI >>> pre-commit hooks.
I would greatly appreciate if we don't add any hooks to slow down our workflow

[estensen]

Not sure why I'm not able to repro failures locally

rustc 1.82.0 (f6e511eec 2024-10-15)

[merklefruit]

Not sure why I'm not able to repro failures locally

rustc 1.82.0 (f6e511eec 2024-10-15)

same