Skip to content

Commit

Permalink
fix: add missing spans in multisig logs (#4239)
Browse files Browse the repository at this point in the history
  • Loading branch information
msgmaxim authored Nov 15, 2023
1 parent 845cbd5 commit 8b7098f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
10 changes: 3 additions & 7 deletions engine/multisig/src/client/ceremony_runner.rs
Original file line number Diff line number Diff line change
Expand Up @@ -113,12 +113,7 @@ where
if let Some(start_instant) = ceremony_start {
let duration = start_instant.elapsed().as_millis();
runner.metrics.ceremony_duration.set(duration);
tracing::info!(
"Ceremony {} ({}) took {}ms to complete",
Ceremony::CEREMONY_TYPE,
ceremony_id,
duration
);
span.in_scope(|| tracing::info!("Ceremony took {}ms to complete", duration));
}
let _result = runner.outcome_sender.send((ceremony_id, outcome));
Ok(())
Expand Down Expand Up @@ -222,7 +217,8 @@ where
}

/// Process message from a peer, returning ceremony outcome if
/// the ceremony stage machine cannot progress any further
/// the ceremony stage machine cannot progress any further.
/// Note: this is only public because of tests.
pub async fn process_or_delay_message(
&mut self,
sender_id: AccountId,
Expand Down
1 change: 1 addition & 0 deletions engine/multisig/src/client/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -371,6 +371,7 @@ impl<C: ChainSigning, KeyStore: KeyStoreAPI<C>> MultisigClientApi<C::CryptoSchem
(reported_parties, failure_reason)
})
}
.instrument(span.clone())
.boxed()
} else {
// No key was found for the given key_id
Expand Down

0 comments on commit 8b7098f

Please sign in to comment.