-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signer Network generates invalid signature rarely #32
Labels
bug
Something isn't working
Comments
rantan
changed the title
Signer Network generate invalid signature rarely
Signer Network generates invalid signature rarely
Jan 17, 2020
The proof verification are failed at this row |
I founded out the cause of this and reported it here. For the present, I'm going to create sign function and use it no longer mullti-party-schnorr crate one. |
rantan
added a commit
to rantan/tapyrus-signer
that referenced
this issue
Feb 4, 2020
rantan
added a commit
to rantan/tapyrus-signer
that referenced
this issue
Feb 4, 2020
rantan
added a commit
to rantan/tapyrus-signer
that referenced
this issue
Feb 5, 2020
rantan
added a commit
to rantan/tapyrus-signer
that referenced
this issue
Feb 6, 2020
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Premise
Aggregated Public Key:
0313a906d2bbb008c3738b7cafcac215b578f66b5a2faabba26d85dc86b2bee854
Block Hex:
0100000073287193ee70a3a5f1ec486106f299a87dca01af4587efdaa2f844df36c8ad61243373c9d02424465cc2a322cd34b4848bf11ca7b967b0304b7b6c812953cdd2dd9df9f2c9e584aaefbf119c6fbedcc5b1eca4660bb884b043abead856925e8ef989205e0040b62ef54ed4e4f541cc3dd79f39ad443f5d0b230be1c88b26a2ce15770566e3cd5623f4df95618bbd1d8ebf8b9d29a120803889fc76d60aeeeda798dd78ec30c101010000000100000000000000000000000000000000000000000000000000000000000000009a01000005029a010101ffffffff02807c814a000000001976a914b0fbdf26cc959f6370ade6b9a0855c83c611858488ac0000000000000000266a24aa21a9ede2f61c3f71d1defd3fa999dfa36953755c690689799962b48bebd836974e8cf900000000
Proof Hex:
b62ef54ed4e4f541cc3dd79f39ad443f5d0b230be1c88b26a2ce15770566e3cd5623f4df95618bbd1d8ebf8b9d29a120803889fc76d60aeeeda798dd78ec30c1
logs
This is full log for the failure round.
open
Proof validity
I checked validity of the proof with below code on Tapyrus Core code base. And the check was failure.
We need to determine the cause of wrong proof generation. In addition, Signer node execute verification of the proof before call submitblock RPC, but it seems pass the check. It means there are possibility which the verification logic is different among Tapyrus Core and Tapyrus Signer.
The text was updated successfully, but these errors were encountered: