Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] POST /users/ to signup #6

Closed
Tracked by #5
championswimmer opened this issue Nov 1, 2023 · 5 comments
Closed
Tracked by #5

[api] POST /users/ to signup #6

championswimmer opened this issue Nov 1, 2023 · 5 comments

Comments

@championswimmer
Copy link
Owner

No description provided.

@championswimmer championswimmer converted this from a draft issue Nov 1, 2023
@shawshankkumar
Copy link

What kind of sign up auth are we looking at?

email pass?
google oauth?

@FaizBShah
Copy link
Contributor

Hey @championswimmer, can I restructure the folder and file structures a little bit? For example, I feel the entities should actually be referred as models and be inside the models package, and the stuffs which we are referring as models are actually just DTO, so it should be inside a dto package, if that makes sense. Also, thinking about handling errors instead of just lo.Must() while doing this PR. Is that ok, or should I tone it down?

@championswimmer
Copy link
Owner Author

@FaizBShah

  1. yes dto and models is right, that should change. you can send 1 PR just to rename that - happy to accept that

  2. handling errors - I want to keep things lo.Must wherever the error should be crashing the server (there are things that must be fatal in nature) for everything else, yes should be handled. for example, if we are unable to connect to db, it should be fatal and starting the server has no point in that scenario.

@FaizBShah
Copy link
Contributor

Cool, got it!!! Raising a PR for the folder structure change

@lohit97
Copy link

lohit97 commented Nov 1, 2023

Raised PR#9 for User SignUp.

Can add - Email Regex Check, Domain Lookup, Email Verification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

4 participants