Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub: add information about who closes and approves the PR #1090

Open
canasdiaz opened this issue Nov 29, 2022 · 0 comments
Open

GitHub: add information about who closes and approves the PR #1090

canasdiaz opened this issue Nov 29, 2022 · 0 comments

Comments

@canasdiaz
Copy link
Contributor

Many review processes performed with GitHub depend on a team cloning a changeset, passing some tests and merging in a different commit. That is not visible with the standard GitHub tools, as the PRs are marked as closed without merged, while in reality the code is merged.

Some examples of this can be found in the Angular and Bazel communities:

It is not possible to measure this with the standard metrics, but offering more information in the GitHub indexes may allow us to do it. What we need to display this metrics in our dashboards is to have extra information in the indexes where we have a document per PR. It can be the github_issues index, the github_pull_requests or both.

The extra information we need is:

  • who closes the PR
  • who approves the PR: this will be a multi-valued field
  • who is pending to approve the PR: this will be a multi-valued field

This information is currently available in the github_events index, but with the current dashboard it is not possible to concatenate queries. We need this data in a single document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants