Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to use Node's ES modules by default for both TS and JS users #902

Open
rwjblue opened this issue Mar 23, 2021 · 1 comment
Open

Migrate to use Node's ES modules by default for both TS and JS users #902

rwjblue opened this issue Mar 23, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@rwjblue
Copy link
Member

rwjblue commented Mar 23, 2021

See the docs here:

https://nodejs.org/api/esm.html
@rwjblue rwjblue added the enhancement New feature or request label Mar 23, 2021
@scalvert scalvert mentioned this issue Mar 29, 2021
Merged
@scalvert scalvert added this to the v1.0.0 milestone Mar 31, 2021
@scalvert
Copy link
Contributor

Looking into this, it was very easy to convert all packages to output es modules vs. commonjs. It was largely achieved via tsconfig.json modification.

The main challenge preventing this from being implemented and shipped right now is the jest support. Support for esmodules in jest is experimental right now, and as such it wasn't easy to configure. We'll keep an eye on this, but this shouldn't block the 1.0 release, so removing this from the milestone for now.

@scalvert scalvert removed this from the v1.0.0 milestone Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rwjblue @scalvert