Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MORNING SESSION CODE REVIEW [MODULE 2 WEEK1] #4

Open
1 task
shuja-shah opened this issue Aug 2, 2022 · 0 comments
Open
1 task

MORNING SESSION CODE REVIEW [MODULE 2 WEEK1] #4

shuja-shah opened this issue Aug 2, 2022 · 0 comments

Comments

@shuja-shah
Copy link

shuja-shah commented Aug 2, 2022

Suggestion From Shuja

Hello Thank you for sharing this beautiful site with your team 😄 , I must confess this site is impressive. Please Take these suggestions from your morning session team to make your site fill with richness 🌹

5Sa

Highlights

  • Great Flow of Code 👍🏻
  • No linter Highlights 💯
  • Beautiful UI and Impressive User Experience. 🥇

Suggestion.

  • Please Implement Keyboard Compatibility to ensure full Accessibility.
    Ensuring Full Accessibility to everyone is beneficial to everyone 😄.
    I can see that you are already adding the hover effect, You can achieve keyboard compatibility by using some additional effects called

focus (For the Navigation) and focus-within (For The Cards).

Suggestion From Bakhthiyor

  • Please, remove empty lines in your index.html code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant