Merge pull request #10 from chiafactory/race-conditions

Avoid potential race condition
chiafactory · Sep 11, 2021 · 4997300 · 4997300
2 parents 6688b5b + ff84dce
commit 4997300
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/plot/plot.go b/plot/plot.go
@@ -491,14 +491,12 @@ func (p *Plot) RetryDownload(ctx context.Context) (err error) {
 
 func (p *Plot) Download(ctx context.Context) (err error) {
 	ctx, cancel := context.WithCancel(ctx)
-	defer func() {
-		cancel()
-		p.cancelDownload = nil
-	}()
-
 	p.cancelDownload = cancel
 
 	defer func() {
+		p.cancelDownload()
+		p.cancelDownload = nil
+
 		if err != nil {
 			log.Errorf("%s download failed: %s", p, err.Error())
 			p.updateDownloadState(DownloadStateFailed)