Use taggable security group rule resources

[nitrocode]

These resources are taggable

• aws_vpc_security_group_ingress_rule
• aws_vpc_security_group_egress_rule

The older aws_security_group_rule is not taggable

Also the inline security group rules are also not taggable

The import terraform/tofu blocks may be able to help with the transition. If not, then release docs would be helpful.

Thank you for considering

[bwhaley]

Should be able to do this with moved blocks. PRs welcome!

[nitrocode]

I don't think the rules can be moved using moved blocks or tf state mv since they are different resources even though both create sg rules.

I'll try to PR this in when I have some time

[bwhaley]

Oh, yeah, you're right. Can't use moved since they are different resource types. This would be a backward incompatible change that would require some careful handling to do without removing and then re-adding the rule. We can document how to do it in the release notes. I'd probably wait a bit before pushing this out given all the recent changes in the repo.