Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add APIs to omit module prefix separator #4532

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

jackkoenig
Copy link
Contributor

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Feature (or new API)

Desired Merge Strategy

  • Squash

Release Notes

  • withModulePrefix now optionally takes a 2nd parameter includeSeparator (passing false will omit separator).
  • Overriding localModulePrefixUseSeparator in a Module to false will omit separator for local prefix applied by overriding localModulePrefix in that Module.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig jackkoenig added the Feature New feature, will be included in release notes label Nov 26, 2024
@jackkoenig jackkoenig added this to the 7.0 milestone Nov 26, 2024
@jackkoenig jackkoenig requested a review from mwachs5 November 26, 2024 23:38
Comment on lines -244 to -247

def getModulePrefixList: List[String] = {
Builder.getModulePrefixList
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this API because it's complicated by the separator being optional and it isn't currently used (it was used internally in Instantiate but its use would technically be wrong with separator now being optional).

Copy link
Contributor

@mwachs5 mwachs5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving, though we could add one more test case for showing the sep override is only for one layer of hierarchy

@jackkoenig jackkoenig force-pushed the prefix-omit-seperator branch from 1109420 to 90635f0 Compare November 26, 2024 23:55
@jackkoenig jackkoenig enabled auto-merge (squash) November 26, 2024 23:55
@jackkoenig jackkoenig merged commit c60ef2f into main Nov 27, 2024
13 checks passed
@jackkoenig jackkoenig deleted the prefix-omit-seperator branch November 27, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants