-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate new atom mappers #1204
Comments
This requires refactoring the objects so that they accept atom maps instead of generating them on the fly. |
Wwe could also try https://github.com/michellab/BioSimSpace/blob/devel/python/BioSimSpace/Align/_align.py#L719 caveat: I think it uses interconversion of the RDKit mol to a SireMol to get to the atom mapping. This may not be ideal |
@ijpulidos we're doing a lot of work on the openfe side to add new mappers (lomap, kartograf, and others eventually). Would it not make more sense for perses to instead directly plug into those mappers? |
Yes! That makes a lot of sense. |
Time machine mapper is in https://github.com/proteneer/timemachine/blob/master/timemachine/fe/atom_mapping.py |
cc'ing @richardjgowers |
@ijpulidos you should probably think about Licenses if you're looking in BSS. And yes if you refactor so that the AtomMapping is an input then it will be relative easy to get this from Lomap/Kartograf/etc, I think wrapping up TimeMachine's approach is interesting, it's a more modern look at what rdFMCS can do compared to other options. |
We should be able to integrate other atom mappers such as the TimeMachine mapper or similar, that we could use in perses for doing the mapping.
The text was updated successfully, but these errors were encountered: