Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate new atom mappers #1204

Open
ijpulidos opened this issue Jun 13, 2023 · 7 comments
Open

Integrate new atom mappers #1204

ijpulidos opened this issue Jun 13, 2023 · 7 comments

Comments

@ijpulidos
Copy link
Contributor

We should be able to integrate other atom mappers such as the TimeMachine mapper or similar, that we could use in perses for doing the mapping.

@ijpulidos
Copy link
Contributor Author

This requires refactoring the objects so that they accept atom maps instead of generating them on the fly.

@ijpulidos
Copy link
Contributor Author

ijpulidos commented Jun 13, 2023

Wwe could also try https://github.com/michellab/BioSimSpace/blob/devel/python/BioSimSpace/Align/_align.py#L719

caveat: I think it uses interconversion of the RDKit mol to a SireMol to get to the atom mapping. This may not be ideal

@IAlibay
Copy link

IAlibay commented Jun 13, 2023

@ijpulidos we're doing a lot of work on the openfe side to add new mappers (lomap, kartograf, and others eventually). Would it not make more sense for perses to instead directly plug into those mappers?

@ijpulidos
Copy link
Contributor Author

@ijpulidos we're doing a lot of work on the openfe side to add new mappers (lomap, kartograf, and others eventually). Would it not make more sense for perses to instead directly plug into those mappers?

Yes! That makes a lot of sense.

@ijpulidos
Copy link
Contributor Author

@IAlibay
Copy link

IAlibay commented Jun 13, 2023

cc'ing @richardjgowers

@richardjgowers
Copy link

@ijpulidos you should probably think about Licenses if you're looking in BSS. And yes if you refactor so that the AtomMapping is an input then it will be relative easy to get this from Lomap/Kartograf/etc, I think wrapping up TimeMachine's approach is interesting, it's a more modern look at what rdFMCS can do compared to other options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants