Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module is not at v1.0 #7

Open
Szeraax opened this issue Jul 2, 2022 · 2 comments
Open

Module is not at v1.0 #7

Szeraax opened this issue Jul 2, 2022 · 2 comments

Comments

@Szeraax
Copy link
Collaborator

Szeraax commented Jul 2, 2022

@choovick, I've done a code review and feel like there aren't any issues that i would say prevent it from being ready for a v1.0 release, Are there any things that you'd recommend I look at or do before I mark this as v1 ready?

@alexeyatbluescape
Copy link

I got no objections! Thou I noticed you renamed some function parameters and not sure if you want to leave them around for backward compatibility... Thou major version change can contain breaking changes, so that's fine. Might want to regenerate help block in the readme.md

@Szeraax
Copy link
Collaborator Author

Szeraax commented Jul 2, 2022

Ya, I left them in because I don't see any good reason for a breaking change at this time. Added deprecation for the function name change I made.

I will change up that help block. Thanks for making this nice module :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants