You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@choovick, I've done a code review and feel like there aren't any issues that i would say prevent it from being ready for a v1.0 release, Are there any things that you'd recommend I look at or do before I mark this as v1 ready?
The text was updated successfully, but these errors were encountered:
I got no objections! Thou I noticed you renamed some function parameters and not sure if you want to leave them around for backward compatibility... Thou major version change can contain breaking changes, so that's fine. Might want to regenerate help block in the readme.md
@choovick, I've done a code review and feel like there aren't any issues that i would say prevent it from being ready for a v1.0 release, Are there any things that you'd recommend I look at or do before I mark this as v1 ready?
The text was updated successfully, but these errors were encountered: