Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form localstorage does not store select menus, checkboxes, or other input types #1657

Open
chrisblakley opened this issue Apr 16, 2018 · 5 comments
Labels
Frontend (Script) Related to the client-side JavaScript.
Milestone

Comments

@chrisblakley
Copy link
Owner

Checkboxes, selects, date, and other non-text input types are not captured by the Nebula localstorage function.

@chrisblakley chrisblakley added the Frontend (Script) Related to the client-side JavaScript. label Apr 16, 2018
@chrisblakley chrisblakley added this to the 6.0 Ant milestone Apr 16, 2018
@chrisblakley
Copy link
Owner Author

Maybe its fine to ignore "acceptance" style checkboxes.

@chrisblakley chrisblakley modified the milestones: 6.0 Ant, 7.0 TBD May 19, 2018
@chrisblakley
Copy link
Owner Author

I may table this issue in favor of upcoming KV Storage: #1832

@patphg
Copy link
Contributor

patphg commented Dec 8, 2020

Looking into this. Is there a tricky reason you never added more input types?

@chrisblakley
Copy link
Owner Author

chrisblakley commented Dec 8, 2020

Not necessarily– just low priority as far as use cases go. They'll need their own event listeners and can't use the same "filler" as-is since it currently just works for strings.

An example edge-case: imagine a radio checkbox (either with 1 or multiple options). If we expand this to store the selected value, that may "soft lock" the user into not ever being able to de-select that input.

@patphg
Copy link
Contributor

patphg commented Dec 16, 2020

#2098

@chrisblakley chrisblakley modified the milestones: 10.0 Cygnus X, 11.0 TBD May 1, 2022
@chrisblakley chrisblakley modified the milestones: 11.0 Carina, 12.0 Flame May 1, 2023
@chrisblakley chrisblakley modified the milestones: 12.0 Flame, 13.0 Bubble May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend (Script) Related to the client-side JavaScript.
Projects
None yet
Development

No branches or pull requests

2 participants