Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptations should be able to implement custom type detection #286

Open
christofmuc opened this issue Oct 15, 2023 · 0 comments
Open

Adaptations should be able to implement custom type detection #286

christofmuc opened this issue Oct 15, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@christofmuc
Copy link
Owner

The meta data field type currently only works for C++ synths implementing the data type protocol. We could make a simple call like

def typeOfPatch(messages) -> str: ...

to have the adaptation to calculate the type for display. This is useful for debugging, but can also help to differentiate different patch versions etc. Think Roland with their JV-80, JV-90, JV-1080, XV-3050 etc types. Or Access Virus A, B, C.

Additionally, we could make a generic "createUserComment" function that is used to prepopuate the new comment field (see #71).

@christofmuc christofmuc added the enhancement New feature or request label Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant