Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum spanning tree for each cluster vs. entire data set? #16

Open
rkingan opened this issue Apr 22, 2021 · 0 comments
Open

Minimum spanning tree for each cluster vs. entire data set? #16

rkingan opened this issue Apr 22, 2021 · 0 comments

Comments

@rkingan
Copy link

rkingan commented Apr 22, 2021

Thank you for publishing this DBCV implementation. I believe, however, that there is an error in the logic. On page 842 of the paper, regarding the minimum spanning tree computations, the paper states:

Based on the MRDs, a Minimum Spanning Tree (MSTMRD ) is then built. This process is repeated for all the clusters in the partition, resulting in l minimum spanning trees, one for each cluster.

In this implementation, however, it appears that only one MST is being created for the entire data set: https://github.com/christopherjenness/DBCV/blob/master/DBCV/DBCV.py#L90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant