Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle nans in the input data #315

Closed
djinnome opened this issue Aug 3, 2023 · 2 comments · Fixed by #458
Closed

Gracefully handle nans in the input data #315

djinnome opened this issue Aug 3, 2023 · 2 comments · Fixed by #458
Assignees
Labels
enhancement New feature or request testing

Comments

@djinnome
Copy link
Contributor

djinnome commented Aug 3, 2023

This might be a problem for @fivegrant but if we receive nans in the dataset that is given to us, we shouldn't try to interpret it, we should instead drop those calibration events.

@djinnome
Copy link
Contributor Author

djinnome commented Aug 3, 2023

We already handle missing data, we should handle nans in the same way.

@SamWitty SamWitty added enhancement New feature or request testing labels Dec 19, 2023
@sabinala sabinala self-assigned this Feb 13, 2024
@anirban-chaudhuri anirban-chaudhuri linked a pull request Feb 14, 2024 that will close this issue
@SamWitty
Copy link
Contributor

Closing, as this is out-of-scope for our service. We assume that NANs will have been caught and pruned in the TA4 service. We can however return an error if we see NANs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants