Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyciemss.sample throws error when the initial condition expressions contain just an integer #599

Closed
liunelson opened this issue Aug 16, 2024 · 1 comment · Fixed by #604

Comments

@liunelson
Copy link
Contributor

This bug occurs when the AMR initials expressions are all strings containing just an integer.
For example (SIR (integers).json):

      "initials": [
        {
          "target": "R",
          "expression": "0",
          "expression_mathml": "<math></math>"
        },
        {
          "target": "I",
          "expression": "1",
          "expression_mathml": "<math></math>"
        },
        {
          "target": "S",
          "expression": "100",
          "expression_mathml": "<math></math>"
        }
      ]

No error is thrown if one appends a .0 to each of the expressions (SIR (floats).json).

Screenshot 2024-08-16 at 3 16 32 PM

SIR (floats).json
SIR (integers).json

@liunelson
Copy link
Contributor Author

I recreated the issue from the Terarium repo to here for tracking.

@SamWitty SamWitty linked a pull request Aug 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant