Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain add domain manager, when existing domain manager, sends email before erroring #3367

Open
dave-kennedy-ecs opened this issue Jan 17, 2025 · 0 comments · May be fixed by #3369
Open

Domain add domain manager, when existing domain manager, sends email before erroring #3367

dave-kennedy-ecs opened this issue Jan 17, 2025 · 0 comments · May be fixed by #3369
Assignees
Labels
bug Something that isn't working as intended dev issue is for the dev team Feature: 🏢 Org Model

Comments

@dave-kennedy-ecs
Copy link
Contributor

Current Behavior

In Domain management, Domain Managers tab, Add a domain manager
Attempt to add a domain manager, for an existing user who is already a domain manager for the domain
An email is sent to the domain manager, and then an error is presented to the user

Expected Behavior

When the existing user is added, no email should be sent, and the AlreadyDomainManagerError should be raised by the code in send_domain_invitation_email

Steps to Reproduce

1.Manage a Domain, and navigate to Domain managers
2.Add an email address that is already listed as a domain manager

Environment

No response

Additional Context

Image
Note in the code snippet above that the checks for existing invitations only checks for retrieved domain invitations, and doesn't account for users who were directly given the UserDomainRole without an invitation

Issue Links

No response

@dave-kennedy-ecs dave-kennedy-ecs added the bug Something that isn't working as intended label Jan 17, 2025
@dave-kennedy-ecs dave-kennedy-ecs added the dev issue is for the dev team label Jan 17, 2025
@abroddrick abroddrick moved this from 👶 New to 🎯 Ready in .gov Product Board Jan 17, 2025
@dave-kennedy-ecs dave-kennedy-ecs self-assigned this Jan 17, 2025
@dave-kennedy-ecs dave-kennedy-ecs moved this from 🎯 Ready to 👀 In review in .gov Product Board Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that isn't working as intended dev issue is for the dev team Feature: 🏢 Org Model
Projects
Status: 👀 In review
Development

Successfully merging a pull request may close this issue.

2 participants