avoid wrong assembly code for threaded mode on ARMv5 and earlier #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes a
tpb32lbuild work for ARM before ARMv6 — including thearmelDebian build, as opposed toarmhf.The main obstacle to supporting older Arm processors directly is that the "arm32.ss" backend currently uses hardware-supported floating point instructions via the VFP extension, which means ARMv6 and later. A software floating-point mode could be added (or restored, since it looks like there may have been one at some point?), but my guess is that there isn't any demand at the moment. Meanwhile, this simple change at least lets
tpb32lbuild.See also racket/racket#4955.