Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config option to disable github version checks #313

Open
cpretzer opened this issue Apr 25, 2023 · 2 comments
Open

Add config option to disable github version checks #313

cpretzer opened this issue Apr 25, 2023 · 2 comments

Comments

@cpretzer
Copy link

cpretzer commented Apr 25, 2023

Using the civo CLI (especially while testing script) causes a lot of version checks to the GitHub API when the VersionCheck method is called from various places.

I'd like a configuration option to disable the version check.

I've forked the repo and want to start working on this, and would appreciate guidance on how the config file is modified and consumed.

So far, I've got a working version that adds a condition to the statement to determine whether the version check should be called.

@alejandrojnm
Copy link
Member

The last version of the CLI only checks that every 24h

@cpretzer
Copy link
Author

I saw that line of code, but that doesn't seem to be the case for me. Perhaps I'm doing something unexpected by calling the civo CLI from within a bash script?

What I'm seeing is that GH is throttling my calls after a few runs of my script.

Upon looking closer at the code, I think I might be looking in the wrong place. The CivoAPIClient function calls common.VersionCheck() without any condition on whether it should be making that call to the GitHub API. Do you think this might be the cause?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants