Wrong region displayed in message when no resources found

[fernando-villalba]

Issue

When you run the following command:

 civo instance --region nyc1 ls

And no resources are found, the wrong region will display in the message, here are examples when default region set to LON1

This is because when issue 404 was implemented the region output is set to show the default as shown here:

Acceptance criteria

• Ensure that the correct region shows on the output message when listing resources in a region where there are no resources.

[Praveen005]

Hi Team,

I just looked into this issue and to solve it,

we can write a check in FinishAndPrintOutput() like below, as using civo instance --region nyc1 ls command will set common.RegionSet to nyc1

       if len(ow.Values) == 0 {
                var region string
                if common.RegionSet != ""{
                    region = common.RegionSet
                }else{
		    region = config.Current.Meta.DefaultRegion
		}
		fmt.Fprintf(os.Stderr, "No resources found in region %s. For a list of regions use the command 'civo region ls'\n", region)
	}

I kindly request your review.

Regards,

Praveen

[haardikdharma10]

That looks good to me @Praveen005. Do you want to open a PR with that change along with a screenshot that the command works and i'd be happy to approve and merge.

[Praveen005]

Hey, @haardikdharma10 ,

when I run the command it doesn't go through, since I don't have an active civo account. Can you kindly test the changes on your end?

Thank you.

[haardikdharma10]

@Praveen005 - I tested the change and it works as expected. I have merged the PR and closing this issue. The change should be visible when we release our next version.