Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested JSON structure for lines and fiducials #22

Open
mariakakis opened this issue Mar 26, 2020 · 2 comments
Open

Nested JSON structure for lines and fiducials #22

mariakakis opened this issue Mar 26, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@mariakakis
Copy link
Collaborator

Right now, the code only accommodates up to 3 lines and 1 fiducial. I can imagine cases where people would want to use more than one fiducial, and I've seen RDTs with more than 3 lines (https://www.medicalogy.com/images/product/thumb_rapid-test-malaria-pf-pv-whole-blood.png). Ignore for now, but might be nice for later

@mariakakis mariakakis added the enhancement New feature or request label Mar 26, 2020
@hungngo97
Copy link
Collaborator

You mean like an array of Fiducial object and Line object right (with their position and width) ? Agreed.

@mariakakis
Copy link
Collaborator Author

Pretty much, but this is very low priority since it could break lots of things if we aren't careful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants