Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CBM should support labeling an EFI boot entry so it's easier to identify a CL partition #177

Open
bktan8 opened this issue Sep 19, 2019 · 6 comments

Comments

@bktan8
Copy link

bktan8 commented Sep 19, 2019

Right now, if there are multiple partitions on a hard drive, it's hard to know which one is Clear Linux or some other OS. It would be nice if CBM can label a Clear partition with the version number as well.

@dorileo
Copy link
Contributor

dorileo commented Sep 23, 2019

What's the point of having the version number in the label?

@ahkok
Copy link
Contributor

ahkok commented Sep 23, 2019

The version number will continuously change, and therefore be wrong most of the time.

No issue with the installer labelling the rootfs during installation, but this should not be a clr-boot-manager thing.

@ahkok
Copy link
Contributor

ahkok commented Sep 23, 2019

Ah you mean label the menu entry. Sorry, misread.

@ahkok
Copy link
Contributor

ahkok commented Sep 23, 2019

I'd think that the boot menu labels already properly distinguish between Clear Linux OS and other OSs....

@mdhorn
Copy link
Contributor

mdhorn commented Sep 23, 2019

I believe @bktan8 complaint has to do with this image:
multiOS

Note that cbm added three entries -- all show precisely the same even though they are booting differently. Also, this does not truly identify the OS as Clear Linux* OS.

@dorileo
Copy link
Contributor

dorileo commented Jan 31, 2020

In the commit c4e4903 I introduced a build flag to do that, we've not changed the packaging yet to pass the flag with something like "Clear Linux OS". I assume this would be enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants