Merge pull request #925 from qtomlinson/qt/sync_curation

Retrieve closed pull requests from oldest to newest during syncAllContributions
clearlydefined · Feb 16, 2022 · ee816ba · ee816ba
2 parents 81df6ab + 785f9c8
commit ee816ba
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/providers/curation/github.js b/providers/curation/github.js
@@ -54,12 +54,15 @@ class GitHubCurationService {
   async syncAllContributions(client) {
     const states = ['open', 'closed']
     for (let state of states) {
-      let response = await client.pullRequests.getAll({
+      let prOptions = {
         owner: this.options.owner,
         repo: this.options.repo,
         per_page: 100,
         state
-      })
+      }
+      //See https://docs.github.com/en/rest/reference/pulls#list-pull-requests
+      if (state === 'closed') prOptions = { ...prOptions, sort: 'updated', direction: 'asc' }
+      let response = await client.pullRequests.getAll(prOptions)
       this._processContributions(response.data)
       while (this.github.hasNextPage(response)) {
         response = await this.github.getNextPage(response)