chore(joint-core): replace rollup buble with rollup babel #2741
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace rollup buble with rollup babel. Added comment about failing case.
Motivation and Context
This allows the user to write newer ES features in
src
code.Notes:
karma
anduglify
dependencies were updated in order to run without errors forES6
code.utilHelpers.mjs
updateAs everything isn't transpiled to ES5 anymore, we had an error in the following tests:
joint/packages/joint-core/test/jointjs/utilHelpers.js
Lines 1382 to 1416 in 58df31d
The
let
causes a reference error in the following lines. This was working previously because it was transpiled tovar
. This change updates to an explicit use ofvar
.joint/packages/joint-core/src/util/utilHelpers.mjs
Lines 680 to 685 in 58df31d
Lodash
is now usingTS
, but was usingvar
in previousJS
code.https://github.com/lodash/lodash/blob/c6e281b878b315c7a10d90f9c2af4cdb112d9625/_equalByTag.js#L82