Use actual types for api responses, not ad-hoc json!() objects
#1931
+138
−115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolreader18
force-pushed
the
noa/formalize-json-responses
branch
from
99d70ed
to
5361630
Compare
coolreader18
force-pushed
the
noa/formalize-json-responses
branch
from
5361630
to
0c08479
Compare
In the extremely unlikely/basically impossible event that serializing json fails, `axum::Json::into_response()` will return a Response with a 500 status code. Explicitly specifying `StatusCode::OK` will overwrite that, returning a 200 even when the response is an error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
No behavior change, but it feels important to be able to see the actual structure of the response, especially as we're stabilizing.
Expected complexity level and risk
1
Testing
Was not able to get spacetime-web working to test this, but it's the same schema as it was before, and it matches with the typedef in typescript in spacetime-web.