Inspector: introduce o, : keybindings
#3586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vemv
changed the title
u keybinding which performs cider-open-url-at-pointu, r keybindings
|
@bbatsov I slightly broadened the scope of this PR. |
bbatsov
reviewed
Nov 19, 2023
| | `cider-open-url-at-point` | ||
| | Opens the url at point if found. | ||
|
|
||
| | kbd:[r] |
There was a problem hiding this comment.
Perhaps you can use : for that, as it'd be closer to the cider-mode keybinding for reading an expression from the minibuffer.
bbatsov
reviewed
Nov 19, 2023
cider-inspector.el
Outdated
| @@ -89,13 +89,20 @@ by clicking or navigating to them by other means." | |||
| "\\|[+-.0-9]+") ; nor numbers. Note: BigInts, ratios etc. are interesting | |||
| "Regexp of uninteresting and skippable values.") | |||
|
|
|||
| (defun cider-open-url-at-point () | |||
There was a problem hiding this comment.
Commands in the inspector should be starting with cider-inspector-.
There was a problem hiding this comment.
On a more general note - probably it'd be better to have a single "open" command that just tries a few options. (e.g. file, url, etc).
vemv
changed the title
u, r keybindingso, r keybindings
vemv
changed the title
o, r keybindingso, : keybindings
vemv
force-pushed
the
inspector-open-url
branch
from
d9363de
to
e443115
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:keybinding which performscider-inspect-exprNow the inspector can also double as a REPL 😄
okeybinding which performscider-open-url-at-pointIt's relatively common to inspect objects that contain a URL in it.
onow can open those in the browser.