Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pwsh 7.3 quoting rules compatibility #3593

Merged
merged 1 commit into from
Dec 2, 2023

Conversation

ikappaki
Copy link
Contributor

@ikappaki ikappaki commented Dec 2, 2023

Hi,

could you please review patch to maintain compatibility with pwsh 7.3. It fixes #3588 based on #3590 by @shishini.

It uses the PSNativeCommandArgumentPassing = 'Legacy' flag as explained at https://stackoverflow.com/a/59036879.

A integration test was added for the same, powershell quoting tests updated to accommodate the above var, docs updated.

Thanks

  • The commits are consistent with our contribution guidelines
  • You've added tests (if possible) to cover your change(s)
  • All tests are passing (eldev test)
  • All code passes the linter (eldev lint) which is based on elisp-lint and includes
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the user manual (if adding/changing user-visible functionality)

Co-authored-by: shishini <shishini@users.noreply.github.com>
@vemv vemv merged commit 511b242 into clojure-emacs:master Dec 2, 2023
35 checks passed
@vemv
Copy link
Member

vemv commented Dec 2, 2023

Thanks much @ikappaki @shishini!

A MELPA snapshot will be available soon. The docs are being deployed as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

configure cider to use PowerShell 7.x and not Windows PowerShell 5.1 on windows
2 participants