Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: many messages fail to parse #48

Open
athos opened this issue Nov 15, 2018 · 5 comments
Open

Problem: many messages fail to parse #48

athos opened this issue Nov 15, 2018 · 5 comments

Comments

@athos
Copy link

athos commented Nov 15, 2018

Hi, there 😃

I ran into an error when trying to access the following page:

The error looks as follows:

2018-11-15 14 09 03

I'm suspecting this post on that day is causing it, which includes some strikethrough in a quote.

2018-11-15 15 27 12

@plexus
Copy link
Member

plexus commented Sep 11, 2019

This page is still erroring out. It would be great if in general we could

  • wrap the parsing in a try/catch, and render the raw message when parsing fails
  • log the message somewhere, so we can go through them systematically later.

@plexus
Copy link
Member

plexus commented Sep 16, 2019

@dawran6 how would you feel about trying your hand at this one. At the point where each message gets parsed and converted from markdown to hiccup we should wrap it in a try/catch, and in the catch just return the message unparsed, plus put a println, "Failed to parse message ..."

@dawranliou
Copy link
Collaborator

Absolutely, I'm working on this. Is println the current preferred way of logging?

@plexus
Copy link
Member

plexus commented Sep 16, 2019

Yeah println is fine, we log the stdout of the process. I don't think there's any more proper logging in place yet

@plexus
Copy link
Member

plexus commented Sep 17, 2019

Pages that errored before according to google search console:

https://gist.github.com/90d310374bcdf234bfe4ea5cfb84da1d

Now that we no longer fail completely on parser errors we can look at those pages, find the messages that don't render, and add test cases for them (and then fix the parser :) )

@plexus plexus changed the title Parser error? Problem: many messages fail to parse Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants