Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade metrics reporter to Metrics 3 #99

Open
michaelklishin opened this issue Jan 5, 2015 · 12 comments
Open

Upgrade metrics reporter to Metrics 3 #99

michaelklishin opened this issue Jan 5, 2015 · 12 comments

Comments

@michaelklishin
Copy link
Member

We should investigate if upgrading it to Metrics 3 is feasible.

@michaelklishin
Copy link
Member Author

@ifesdjeen you seem to be on a roll recently, want to tackle this one? ;)

@ifesdjeen
Copy link
Member

@michaelklishin sure boss no problem. let me bring the query api to some borderline stable mergeable state and i'll do that one too :)

@michaelklishin
Copy link
Member Author

We should have an issue for that, as I've completely forgotten you were working on that :)

@jwhitlark
Copy link

@michaelklishin: I was thinking about taking a swing at this. One question, though: Is there any reason this doesn't use metrics-clojure?

@michaelklishin
Copy link
Member Author

@jwhitlark not sure. I think it's reasonable to use metrics-clojure and depend on it since Cassaforte is a Clojure library and it is based on Metrics 3 already.

@jwhitlark
Copy link

Ok, I'll take a look and see if I run into any problems.

@ifesdjeen
Copy link
Member

I can actually recommend using Dropwizard Metrics without any wrapper library. Their api is quite clean and I've found it easier to do it this way, mostly because the documentation of all the existing wrappers isn't as good as original.

As far as I understand, driver is already providing all the "gathering" of data. We only need to read out the information for reporting.

@michaelklishin
Copy link
Member Author

@jwhitlark and I maintain metrics-clojure. So we can figure out the API :)

@ifesdjeen
Copy link
Member

I'm sure you can figure out API, but I'm also a user of the library, and bringing in an extra dependency for something that's very simply done in Java isn't something I've tried to strip down all the extra dependencies for :)

We've tried metrics-clojure in our setup, and it was difficult for us to use, so we switched to pure java implementation. It's also very easy to use.

@jwhitlark
Copy link

Ok, I'm glad to hear what you guys are thinking. Let me take a look and see what makes sense to me after I've read through the code.

@jwhitlark
Copy link

I don't think I'm going to get to this anytime soon. If someone else wants to take it on, feel free.

@michaelklishin
Copy link
Member Author

@jwhitlark no worries, thanks for the update. @ifesdjeen do you want to look into it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants