/controller-info only works when a server-configuration is applied

[bavarianbidi]

In the garm-operator we want to check the version of the connected garm-server.
We are doing this by getting the server version via the /controller-info endpoint.

Unfortunately it's some kind of a chicken-egg problem. We need the version before we start our controller-loops.
To work around this, we've implemented the following patch which applies a "default" configuration just to make the /controller-info endpoint work - mercedes-benz/garm-operator#215

I'm not 100% sure about the intention, but could we probably relax some of the decisions here:

garm/auth/init_required.go

Lines 55 to 80 in 237afdb

	func NewUrlsRequiredMiddleware(store common.Store) (Middleware, error) {
	return &urlsRequired{
	store: store,
	}, nil
	}
	type urlsRequired struct {
	store common.Store
	}
	func (u *urlsRequired) Middleware(next http.Handler) http.Handler {
	return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
	ctx := r.Context()
	ctrlInfo, err := u.store.ControllerInfo()
	if err != nil || ctrlInfo.WebhookURL == "" || ctrlInfo.MetadataURL == "" || ctrlInfo.CallbackURL == "" {
	w.Header().Add("Content-Type", "application/json")
	w.WriteHeader(http.StatusConflict)
	if err := json.NewEncoder(w).Encode(params.URLsRequired); err != nil {
	slog.With(slog.Any("error", err)).ErrorContext(ctx, "failed to encode response")
	}
	return
	}
	next.ServeHTTP(w, r.WithContext(ctx))
	})
	}

[gabriel-samfira]

Hi @bavarianbidi

Cound you try the following routes and let me know if they work for you:

garm/apiserver/routers/routers.go

Lines 158 to 170 in 7d889f0

	controllerRouter := apiSubRouter.PathPrefix("/controller").Subrouter()
	// The controller endpoints allow us to get information about the controller and update the URL endpoints.
	// This endpoint must not be guarded by the urlsRequiredMiddleware as that would prevent the user from
	// updating the URLs.
	controllerRouter.Use(initMiddleware.Middleware)
	controllerRouter.Use(authMiddleware.Middleware)
	controllerRouter.Use(auth.AdminRequiredMiddleware)
	// Get controller info
	controllerRouter.Handle("/", http.HandlerFunc(han.ControllerInfoHandler)).Methods("GET", "OPTIONS")
	controllerRouter.Handle("", http.HandlerFunc(han.ControllerInfoHandler)).Methods("GET", "OPTIONS")
	// Update controller
	controllerRouter.Handle("/", http.HandlerFunc(han.UpdateControllerHandler)).Methods("PUT", "OPTIONS")
	controllerRouter.Handle("", http.HandlerFunc(han.UpdateControllerHandler)).Methods("PUT", "OPTIONS")

These should not be guarded by the urlsRequired middleware.