-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include LUA for nginx when building ESP #679
Comments
@PiotrSikora your take on this? |
It's possible, since Lua is just another module, that can be built separately from the core, but it requires creating and maintaining BUILD files for it. |
@PiotrSikora - Do you think it is worth building and maintaining this? |
@aashish004 that depends on your use case, really. |
My use case is validation of JWT via cookie, queryParams, or Header (Last one is supported by ESP). The motivation here is to do authentication for all types of clients in one place so that they don't have to do it also for web clients cookie is much secure for me. |
Also If you can please point me to some documentation on how to include external modules while building ESP. |
If just for jwt validation, you can file enhancement issues specifically. ESP currently supports authorization header and "access_token=" query parameter. It doesn't support cookie now, but should be easy to add. The code is here: https://github.com/cloudendpoints/esp/blob/master/src/api_manager/check_auth.cc#L165 |
ESP gets its Nignx with Bazel supports from here. I am not sure if it supports external contributions. Another way is to add the Lua module in ESP. The task is: to add bazel dependencies, bazel BUILD file to build it, and add it to the src/nginx/main/module.cc. You can try to play with it, if it works, submit a PR. |
Is it possible to include LUA for nginx when building ESP
The text was updated successfully, but these errors were encountered: